Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Markdown in custom @family titles #1608

Merged
merged 3 commits into from
Jul 9, 2024
Merged

Support Markdown in custom @family titles #1608

merged 3 commits into from
Jul 9, 2024

Conversation

salim-b
Copy link
Contributor

@salim-b salim-b commented Apr 10, 2024

Parses custom @family titles as Markdown.

@hadley
Copy link
Member

hadley commented Jul 9, 2024

Do the family name also end up in the concept tag?

@salim-b
Copy link
Contributor Author

salim-b commented Jul 9, 2024

Do the family name also end up in the concept tag?

Sorry, I don't understand the question... what are you exactly referring to with "the concept tag"?

AFAICT, the tag arg given to markdown() is only used to create better error and warning msgs...

@hadley
Copy link
Member

hadley commented Jul 9, 2024

I think family names also end up in \concept{}

@salim-b
Copy link
Contributor Author

salim-b commented Jul 9, 2024

I think family names also end up in \concept{}

Yes, the family name, not the value (for which this PR adds Markdown support).

@hadley
Copy link
Member

hadley commented Jul 9, 2024

Ah great.

@hadley hadley merged commit 12c3555 into r-lib:main Jul 9, 2024
13 checks passed
@salim-b salim-b deleted the md-in-family branch July 9, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@salim-b @hadley